Replace global logger with local logger in tlscommon package

[khushijain21]

What does this PR do?

This PR supports additonal options on certain method intlscommon package to accept a local logger.
Note: This PR includes breaking changes as well - but those methods are not used by elastic-agent ensuring the blast radius is small

This is part of the effort to get rid of global states.

Why is it important?

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works

Related issues

• Relates https://github.com/elastic/ingest-dev/issues/5251

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 033fae9

History

• 💚 Build #835 succeeded 573120b
• 💚 Build #834 succeeded ae7d1fb
• 💚 Build #833 succeeded 96d470c

[andrzej-stencel]

I agree a phased approach to the breaking change may help users of this API. Other than that, the PR looks good. I'm approving it from my side and will let @kruskall and @khushijain21 reach a conclusion on the breaking change approach.

[khushijain21]

As discussed in our sync meeting - we would rather do a breaking change now that would cause some churn than have users of this API continue to use global logger.

[kruskall]

As discussed in our sync meeting - we would rather do a breaking change now that would cause some churn than have users of this API continue to use global logger.

the suggestion was to remove the global logger in a backward compatible way. The current method should be updated to use noop logger if nothing is passed.
I've added a comment to #348 (comment)

I'll dismiss my review to unblock but don't feel comfortable approving.

unblock