Skip to content

Include whether Beat is running from a FIPS distribution in User Agent #47409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

Include whether Beat is running from a FIPS distribution in User Agent #47409

merged 4 commits into from
Nov 4, 2025

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 31, 2025

Proposed commit message

This PR includes whether the Beat is running from a FIPS distribution in the User Agent sent by Beats. This allows us to track FIPS usage for Beats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

None.

@ycombinator ycombinator requested review from a team as code owners October 31, 2025 00:00
@ycombinator ycombinator requested review from mauri870 and rdner October 31, 2025 00:00
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

ycombinator
ycombinator commented Oct 31, 2025
View reviewed changes
@ycombinator ycombinator added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 31, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 31, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

mauri870
mauri870 approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending removal of the replace directive.

ebeahan
ebeahan requested changes Oct 31, 2025
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Requesting changes until https://github.com/elastic/beats/pull/47409/files#r2479832526 is completed to avoid an unintentional merging 😄

@ycombinator ycombinator enabled auto-merge (squash) November 3, 2025 21:59
@ycombinator ycombinator merged commit 5df7f06 into elastic:main Nov 4, 2025
208 checks passed
@ycombinator ycombinator deleted the ua-fips branch November 4, 2025 14:14
@orestisfl orestisfl mentioned this pull request Nov 4, 2025
Merged
6 tasks
@belimawr belimawr added the backport-9.1 Automated backport to the 9.1 branch label Nov 5, 2025
@belimawr belimawr added the backport-9.2 Automated backport to the 9.2 branch label Nov 5, 2025
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
@ycombinator @mergify
Include whether Beat is running from a FIPS distribution in User Agent (
d91d095 
#47409)

* Include whether Beat is running from a FIPS distribution in User Agent

* Add unit tests

* Adding CHANGELOG fragment

* Remove temporary replace directive for elastic-agent-libs dependency

(cherry picked from commit 5df7f06)
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
@ycombinator @mergify
Include whether Beat is running from a FIPS distribution in User Agent (
02469bf 
#47409)

* Include whether Beat is running from a FIPS distribution in User Agent

* Add unit tests

* Adding CHANGELOG fragment

* Remove temporary replace directive for elastic-agent-libs dependency

(cherry picked from commit 5df7f06)
This was referenced Nov 5, 2025
Merged
Merged
belimawr added a commit that referenced this pull request Nov 13, 2025
@mergify @ycombinator @belimawr
[9.1](backport #47409) Include whether Beat is running from a FIPS di…
520c449 
…stribution in User Agent (#47485)

(cherry picked from commit 5df7f06)

---------

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Tiago Queiroz <[email protected]>
belimawr added a commit that referenced this pull request Nov 13, 2025
@mergify @ycombinator @belimawr
[9.2](backport #47409) Include whether Beat is running from a FIPS di…
86ed1d3 
…stribution in User Agent (#47486)

(cherry picked from commit 5df7f06)

---------

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Tiago Queiroz <[email protected]>
andrzej-stencel pushed a commit to andrzej-stencel/beats that referenced this pull request Dec 1, 2025
@ycombinator @andrzej-stencel
Include whether Beat is running from a FIPS distribution in User Agent (
0540f80 
elastic#47409)

* Include whether Beat is running from a FIPS distribution in User Agent

* Add unit tests

* Adding CHANGELOG fragment

* Remove temporary replace directive for elastic-agent-libs dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@ebeahan ebeahan ebeahan approved these changes

@mauri870 mauri870 mauri870 approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ycombinator ycombinator

Labels

backport-9.1 Automated backport to the 9.1 branch backport-9.2 Automated backport to the 9.2 branch enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ycombinator @elasticmachine @pierrehilbert @ebeahan @mauri870 @belimawr