[monitoring] Add ClearOnVisitHistogram to adapter for go-metrics #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
the
Team:Elastic-Agent-Data-Plane
leehinman
requested review from
faec and
mauri870
and removed request for
a team
leehinman
force-pushed
the
5882_clearing_histogram
branch
from
7580a8f to
664a29a
Compare
mauri870
approved these changes
Jul 28, 2025
Member
mauri870
left a comment
mauri870
left a comment
There was a problem hiding this comment.
I don't see any obvious issues, but I'm not very experienced with how this integrates with the agent dashboards. I'd give more weight to Fae's review.
leehinman
force-pushed
the
5882_clearing_histogram
branch
from
664a29a to
3230078
Compare
Collaborator
💚 Build Succeeded
History
|
faec
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new type of ClearOnVisitHistogram to monitoring/adapter.
Why is it important?
This type is the same as a go-metrics StandardHistogram, but the Visit function for the new type will call
Clearon the underlying sample. This means the sample is reset each time you visit it. This is useful for things like the beats "Non-zero metrics in the last 30s" log entries.The other difference is that the
Visitfunction only reports the following metrics:This is smaller than the fields produced for the StandardHistogram. This was done to limit the field expansion, and this list of fields was picked because it is the list actually used in the elastic-agent monitoring dashboards.
Checklist
Author's Checklist
Related issues