Skip to content

Conversation

@khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Aug 18, 2025

What does this PR do?

This PR replaces global logger with local logger in monitoring/adpater. adapater package is not used in elastic-agent but only in beats hence breaking changes should less significant impact

A follow up PR will accommodate this in beats

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar concerns as elastic/elastic-agent-system-metrics#259 (review)

this is a binary incompatible change, I think we should first ensure we are able to bump the library in all supported branches

@khushijain21
Copy link
Contributor Author

@kruskall I already have a PR up that accommodates these changes. elastic/beats#46054 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants