Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 1, 2025

What does this PR do?

Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT.

Why is it important?

Prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #11499 done by [Mergify](https://mergify.com).

…timeExperimental (#11499)

Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT.

This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout.

(cherry picked from commit f32807c)
@mergify mergify bot requested a review from a team as a code owner December 1, 2025 19:44
@mergify mergify bot added the backport label Dec 1, 2025
@mergify mergify bot requested review from blakerouse and michel-laterman and removed request for a team December 1, 2025 19:44
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 enabled auto-merge (squash) December 2, 2025 11:16
@mauri870
Copy link
Member

mauri870 commented Dec 2, 2025

CI failure should be fixed by elastic/beats#47829.

@mauri870
Copy link
Member

mauri870 commented Dec 3, 2025

/test

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @mauri870

@mauri870 mauri870 merged commit 5bf2e0f into 8.19 Dec 3, 2025
17 checks passed
@mauri870 mauri870 deleted the mergify/bp/8.19/pr-11499 branch December 3, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants