fix(tests): use assert.CollectT in TestContainerCMDAgentMonitoringRuntimeExperimental #11499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
added
Cleanup
skip-changelog
backport-active-all
swiatekm
previously approved these changes
Dec 1, 2025
Contributor
swiatekm
left a comment
swiatekm
left a comment
There was a problem hiding this comment.
Using the outer testing fixture instead of the inner one in a testify assertion is slowly becoming a modern classic for test flakiness.
Member
Author
|
/test |
Contributor
swiatekm
reviewed
Dec 1, 2025
swiatekm
approved these changes
Dec 1, 2025
Contributor
|
@Mergifyio backport 8.19 9.1 9.2 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
…timeExperimental (#11499) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c)
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
…timeExperimental (#11499) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c)
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
…timeExperimental (#11499) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c)
This was referenced Dec 1, 2025
pierrehilbert
pushed a commit
that referenced
this pull request
Dec 2, 2025
…timeExperimental (#11499) (#11510) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
pierrehilbert
pushed a commit
that referenced
this pull request
Dec 2, 2025
…timeExperimental (#11499) (#11509) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870
added a commit
that referenced
this pull request
Dec 3, 2025
…timeExperimental (#11499) (#11511) Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT. This prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout. (cherry picked from commit f32807c) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates TestContainerCMDAgentMonitoringRuntimeExperimental to use the assert.CollectT instead of the testing.T inside require.EventuallyWithT.
Why is it important?
Prevents the code from failing on the first pass of require.EventuallyWithT. Now it retries transient assertion errors up to the timeout.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues