Add RequestConfigurationDescriptor copy constructor
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
force-pushed
the
requestconfigurationdescriptor-copy-ctor
branch
from
73eeb82 to
0569ac9
Compare
Mpdreamz
approved these changes
Nov 19, 2024
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
There's quite a few
#if NET6_0_OR_GREATER
In the codebase but I am happy for these to remain anchored to 6.
LGTM!
Member
Author
Yes, we should probably just use Thanks for approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RequestConfigurationDescriptorcopy constructor.As well removes
net6TFMs.