Skip to content

Conversation

@rdner
Copy link
Member

@rdner rdner commented Sep 10, 2025

Proposed commit message

The metric name queue.filled.pct.events was changed to queue.filled.pct in v8.15.0 by this commit elastic/beats@f8aedce (PR elastic/beats#39774).

We've fixed the metric name in the package fields by this PR #15244

However, the minimal stack version requirements remained unchanged. This would break any customers running on stack versions 8.11.2 – 8.14.3 and upgrading their Elastic Agent integration to 2.5.2.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Build the package and verify that v2.6.9 is only available on 8.15.0 and later.

@rdner rdner self-assigned this Sep 10, 2025
The metric name `queue.filled.pct.events` was changed to
`queue.filled.pct` in v8.15.0
@rdner rdner force-pushed the change-elastic-agent-version-requirements branch from 5efda6c to 8c5a110 Compare September 10, 2025 09:22
@rdner rdner added bugfix Pull request that fixes a bug issue Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Sep 10, 2025
Comment on lines 3 to 7
- version: "2.5.3"
changes:
- description: Update version requirements due to the breaking change in metric names
type: enhancement
link: "https://github.com/elastic/integrations/pull/15268"
Copy link
Member

@jsoriano jsoriano Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to release this as 2.6.0.

Suggested change
- version: "2.5.3"
changes:
- description: Update version requirements due to the breaking change in metric names
type: enhancement
link: "https://github.com/elastic/integrations/pull/15268"
- version: "2.6.0"
changes:
- description: Update version requirements due to the breaking change in metric names
type: enhancement
link: "https://github.com/elastic/integrations/pull/15268"

After releasing 2.6.0, create a backport branch from 2.5.2, revert the breaking change in this branch, and release a 2.5.3 version from there.

This way stacks >= 8.15.0 will use 2.6.0, and older versions will use the fixed 2.5.3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoriano would it make upgrading to the "broken" 2.5.2 impossible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we release 2.6.0 and 2.5.3 backport first. Then we remove the "broken" 2.5.2 from the registry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.5 backport PR #15273

@rdner rdner marked this pull request as ready for review September 10, 2025 11:43
@rdner rdner requested a review from a team as a code owner September 10, 2025 11:43
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rdner

@elastic-sonarqube
Copy link

@rdner rdner merged commit 9a2ed98 into elastic:main Sep 10, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package elastic_agent - 2.6.0 containing this change is available at https://epr.elastic.co/package/elastic_agent/2.6.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:elastic_agent Elastic Agent Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants