-
Notifications
You must be signed in to change notification settings - Fork 511
Change stack version requirements due to the breaking changes #15268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change stack version requirements due to the breaking changes #15268
Conversation
The metric name `queue.filled.pct.events` was changed to `queue.filled.pct` in v8.15.0
5efda6c to
8c5a110
Compare
packages/elastic_agent/changelog.yml
Outdated
| - version: "2.5.3" | ||
| changes: | ||
| - description: Update version requirements due to the breaking change in metric names | ||
| type: enhancement | ||
| link: "https://github.com/elastic/integrations/pull/15268" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to release this as 2.6.0.
| - version: "2.5.3" | |
| changes: | |
| - description: Update version requirements due to the breaking change in metric names | |
| type: enhancement | |
| link: "https://github.com/elastic/integrations/pull/15268" | |
| - version: "2.6.0" | |
| changes: | |
| - description: Update version requirements due to the breaking change in metric names | |
| type: enhancement | |
| link: "https://github.com/elastic/integrations/pull/15268" |
After releasing 2.6.0, create a backport branch from 2.5.2, revert the breaking change in this branch, and release a 2.5.3 version from there.
This way stacks >= 8.15.0 will use 2.6.0, and older versions will use the fixed 2.5.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano would it make upgrading to the "broken" 2.5.2 impossible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we release 2.6.0 and 2.5.3 backport first. Then we remove the "broken" 2.5.2 from the registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.5 backport PR #15273
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
History
cc @rdner |
|
|
Package elastic_agent - 2.6.0 containing this change is available at https://epr.elastic.co/package/elastic_agent/2.6.0/ |




Proposed commit message
The metric name
queue.filled.pct.eventswas changed toqueue.filled.pctin v8.15.0 by this commit elastic/beats@f8aedce (PR elastic/beats#39774).We've fixed the metric name in the package fields by this PR #15244
However, the minimal stack version requirements remained unchanged. This would break any customers running on stack versions 8.11.2 – 8.14.3 and upgrading their Elastic Agent integration to 2.5.2.
Checklist
changelog.ymlfile.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Build the package and verify that v2.6.9 is only available on 8.15.0 and later.