Skip to content

Conversation

@rdner
Copy link
Member

@rdner rdner commented Sep 10, 2025

Proposed commit message

The metric name queue.filled.pct.events was changed to queue.filled.pct in v8.15.0 by this commit elastic/beats@f8aedce (PR elastic/beats#39774).

We've fixed the metric name in the package fields by this PR #15244

However, the minimal stack version requirements remained unchanged. This would break any customers running on stack versions 8.11.2 – 8.14.3 and upgrading their Elastic Agent integration to 2.5.2.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@rdner rdner self-assigned this Sep 10, 2025
@rdner rdner added Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] Integration:elastic_agent Elastic Agent Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] bugfix Pull request that fixes a bug issue labels Sep 10, 2025
@rdner rdner added the backport label Sep 10, 2025
@rdner rdner changed the title Change stack version requirements due to the breaking changes [Backport] Change stack version requirements due to the breaking changes Sep 10, 2025
Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

@rdner rdner requested a review from VihasMakwana September 10, 2025 13:06
@rdner rdner marked this pull request as ready for review September 10, 2025 13:06
@rdner rdner requested a review from a team as a code owner September 10, 2025 13:06
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert the breaking change on this branch, and keep the previous kibana constraint, so the fix reaches affected installations.

@rdner rdner force-pushed the change-stack-version-requirements-2.5 branch from d88d109 to 4e230a9 Compare September 10, 2025 13:47
@rdner
Copy link
Member Author

rdner commented Sep 10, 2025

After discussing this with @cmacknz we make a decision to close this PR.

The stack constraint wouldn't prevent the original issue. This stack constraint does not control the Elastic Agent version and the breaking change took place in Elastic Agent, not in the stack itself.

@rdner rdner closed this Sep 10, 2025
@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rdner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bugfix Pull request that fixes a bug issue Integration:elastic_agent Elastic Agent Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants