[Security Solution] Unskip prebuilt rule upgrade ML jobs field test #232758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
test
release_note:skip
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
dplumlee
approved these changes
Aug 28, 2025
Contributor
dplumlee
left a comment
dplumlee
left a comment
There was a problem hiding this comment.
LGTM, diff is trivial 👍
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @maximpn |
Contributor
|
Starting backport for target branches: 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 1, 2025
…lastic#232758) **Resolves: elastic#220081 ## Summary This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test. ## Details The Jest integration test `Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of elastic#228620. Thorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time. Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze. (cherry picked from commit f899266)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maximpn
deleted the
unskip-prebuilt-rule-upgrade-ml-job-id-field-test
branch
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2025
…test (#232758) (#233639) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] Unskip prebuilt rule upgrade ML jobs field test (#232758)](#232758) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-01T13:04:57Z","message":"[Security Solution] Unskip prebuilt rule upgrade ML jobs field test (#232758)\n\n**Resolves: https://github.com/elastic/kibana/issues/220081**\n\n## Summary\n\nThis PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test.\n\n## Details\n\nThe Jest integration test `Upgrade diffable rule \"machine_learning_job_id\" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of https://github.com/elastic/kibana/pull/228620.\n\nThorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time.\n\nTaking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.","sha":"f8992660b97d5e6bc660ac08e241490c63e38764","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.2.0","v9.1.3"],"title":"[Security Solution] Unskip prebuilt rule upgrade ML jobs field test","number":232758,"url":"https://github.com/elastic/kibana/pull/232758","mergeCommit":{"message":"[Security Solution] Unskip prebuilt rule upgrade ML jobs field test (#232758)\n\n**Resolves: https://github.com/elastic/kibana/issues/220081**\n\n## Summary\n\nThis PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test.\n\n## Details\n\nThe Jest integration test `Upgrade diffable rule \"machine_learning_job_id\" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of https://github.com/elastic/kibana/pull/228620.\n\nThorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time.\n\nTaking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.","sha":"f8992660b97d5e6bc660ac08e241490c63e38764"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232758","number":232758,"mergeCommit":{"message":"[Security Solution] Unskip prebuilt rule upgrade ML jobs field test (#232758)\n\n**Resolves: https://github.com/elastic/kibana/issues/220081**\n\n## Summary\n\nThis PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test.\n\n## Details\n\nThe Jest integration test `Upgrade diffable rule \"machine_learning_job_id\" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of https://github.com/elastic/kibana/pull/228620.\n\nThorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time.\n\nTaking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.","sha":"f8992660b97d5e6bc660ac08e241490c63e38764"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <[email protected]>
ymao1
pushed a commit
to ymao1/kibana
that referenced
this pull request
Sep 2, 2025
…lastic#232758) **Resolves: elastic#220081 ## Summary This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test. ## Details The Jest integration test `Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of elastic#228620. Thorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time. Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.
MichelLosier
pushed a commit
to MichelLosier/kibana
that referenced
this pull request
Sep 2, 2025
…lastic#232758) **Resolves: elastic#220081 ## Summary This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test. ## Details The Jest integration test `Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of elastic#228620. Thorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time. Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Sep 3, 2025
…lastic#232758) **Resolves: elastic#220081 ## Summary This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test. ## Details The Jest integration test `Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of elastic#228620. Thorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time. Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #220081
Summary
This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test.
Details
The Jest integration test
Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved valuewas skipped earlier in9.1and9.2due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of #228620.Thorough testing in
main(corresponds to9.2) and9.1branches hasn't revealed any failures or flakiness. On top of that this test runs in8.18and8.19smoothly all that time.Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze.