[9.1] [Security Solution] Unskip prebuilt rule upgrade ML jobs field test (#232758) #233639
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#232758) **Resolves: elastic#220081 ## Summary This PR unskips skipped earlier Prebuilt Rule Upgrade workflow ML jobs field Jest integration test. ## Details The Jest integration test `Upgrade diffable rule "machine_learning_job_id" (machine_learning rule type) after preview in flyout customized field w/ an upgrade resulting in a non-solvable conflict (ABC) upgrades rule to resolved value` was skipped earlier in `9.1` and `9.2` due to flakiness. Since that moment combobox integration flakiness has been addressed in the scope of elastic#228620. Thorough testing in `main` (corresponds to `9.2`) and `9.1` branches hasn't revealed any failures or flakiness. On top of that this test runs in `8.18` and `8.19` smoothly all that time. Taking the above into account it should be safe to unskip the skipped test. In case if the flakiness pops up we'll have more data to analyze. (cherry picked from commit f899266)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation