[dashboards as code] move map embeddable reference handling to server #234806

nreese · 2025-09-11T18:25:08Z

PR moves map embeddable reference handling to the server.

dashboard CRUD APIs no longer contain references from map panels. In the screen shot below, notice how indexPatternId contain saved object ids and are not references. Notice how the reference array for the dashboard is empty.

References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how indexPatternId has been replaced with indexPatternRefName and points to a reference that contains the saved objec tid.

nreese · 2025-09-11T20:16:06Z

/ci

nreese · 2025-09-12T00:14:56Z

/ci

nreese · 2025-09-12T01:05:26Z

/ci

elasticmachine · 2025-09-12T02:57:41Z

💚 Build Succeeded

Buildkite Build
Commit: c3f0fe1

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`maps`	331	333	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	3.1MB	3.1MB	-33.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	40.9KB	41.1KB	+183.0B

Unknown metric groups

API count

id	before	after	diff
`maps`	337	339	+2

History

💔 Build #338549 failed 8452b3e

elasticmachine · 2025-09-12T16:38:05Z

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese · 2025-09-15T14:17:47Z

@elasticmachine merge upstream

ThomThomson

This is a really clean diff-set. Nice work! Changes LGTM. Code review only.

ThomThomson · 2025-09-15T18:53:20Z

x-pack/platform/plugins/shared/maps/common/embeddable/transforms/get_transform_in.ts

+        } as StoredMapEmbeddableState,
+        references: [
+          {
+            name: MAP_SAVED_OBJECT_REF_NAME,


This is looking really clear!

ThomThomson · 2025-09-15T19:49:17Z

x-pack/platform/plugins/shared/maps/common/embeddable/transforms/get_transform_out.ts

+    if (savedObjectRef) {
+      return {
+        ...state,
+        ...(enhancementsState ? { enhancements: enhancementsState } : {}),


It could be neat if there was a one-step way to do this.

x-pack/platform/plugins/shared/maps/common/embeddable/types.ts

…elastic#234806) PR moves map embeddable reference handling to the server. dashboard CRUD APIs no longer contain references from map panels. In the screen shot below, notice how `indexPatternId` contain saved object ids and are not references. Notice how the reference array for the dashboard is empty. <img width="2041" height="1014" alt="Screenshot 2025-09-11 at 6 59 55 PM" src="https://github.com/user-attachments/assets/44a7c26c-b189-4c04-9f19-2159068ecc74" /> References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved objec tid. <img width="2046" height="999" alt="Screenshot 2025-09-11 at 7 01 41 PM" src="https://github.com/user-attachments/assets/ecbe6c80-21fb-4a88-8233-5555153d9430" /> --------- Co-authored-by: Elastic Machine <[email protected]>

#235990) #234806 moved references handling for map embeddable to server. This PR does the same thing but for Map application's REST API. Maps CRUD APIs no longer contain references. In the screen shot below, notice how `indexPatternId` contain saved object ids and the only reference is for tags. <img width="1500" height="746" alt="Screenshot 2025-09-23 at 10 38 50 AM" src="https://github.com/user-attachments/assets/0415899d-a032-49a1-a741-36dcb785bf31" /> References are extracted on server and stored in Map saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved object id. <img width="1785" height="876" alt="Screenshot 2025-09-23 at 10 39 33 AM" src="https://github.com/user-attachments/assets/2d88eee2-4f74-44fb-86f2-cf534c75fa58" /> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>

elastic#235990) elastic#234806 moved references handling for map embeddable to server. This PR does the same thing but for Map application's REST API. Maps CRUD APIs no longer contain references. In the screen shot below, notice how `indexPatternId` contain saved object ids and the only reference is for tags. <img width="1500" height="746" alt="Screenshot 2025-09-23 at 10 38 50 AM" src="https://github.com/user-attachments/assets/0415899d-a032-49a1-a741-36dcb785bf31" /> References are extracted on server and stored in Map saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved object id. <img width="1785" height="876" alt="Screenshot 2025-09-23 at 10 39 33 AM" src="https://github.com/user-attachments/assets/2d88eee2-4f74-44fb-86f2-cf534c75fa58" /> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>

…#234806) PR moves map embeddable reference handling to the server. dashboard CRUD APIs no longer contain references from map panels. In the screen shot below, notice how `indexPatternId` contain saved object ids and are not references. Notice how the reference array for the dashboard is empty. <img width="2041" height="1014" alt="Screenshot 2025-09-11 at 6 59 55 PM" src="https://github.com/user-attachments/assets/44a7c26c-b189-4c04-9f19-2159068ecc74" /> References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved objec tid. <img width="2046" height="999" alt="Screenshot 2025-09-11 at 7 01 41 PM" src="https://github.com/user-attachments/assets/ecbe6c80-21fb-4a88-8233-5555153d9430" /> --------- Co-authored-by: Elastic Machine <[email protected]>

#235990) #234806 moved references handling for map embeddable to server. This PR does the same thing but for Map application's REST API. Maps CRUD APIs no longer contain references. In the screen shot below, notice how `indexPatternId` contain saved object ids and the only reference is for tags. <img width="1500" height="746" alt="Screenshot 2025-09-23 at 10 38 50 AM" src="https://github.com/user-attachments/assets/0415899d-a032-49a1-a741-36dcb785bf31" /> References are extracted on server and stored in Map saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved object id. <img width="1785" height="876" alt="Screenshot 2025-09-23 at 10 39 33 AM" src="https://github.com/user-attachments/assets/2d88eee2-4f74-44fb-86f2-cf534c75fa58" /> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>

elastic#235990) elastic#234806 moved references handling for map embeddable to server. This PR does the same thing but for Map application's REST API. Maps CRUD APIs no longer contain references. In the screen shot below, notice how `indexPatternId` contain saved object ids and the only reference is for tags. <img width="1500" height="746" alt="Screenshot 2025-09-23 at 10 38 50 AM" src="https://github.com/user-attachments/assets/0415899d-a032-49a1-a741-36dcb785bf31" /> References are extracted on server and stored in Map saved object. In the screen shot below, notice how `indexPatternId` has been replaced with `indexPatternRefName` and points to a reference that contains the saved object id. <img width="1785" height="876" alt="Screenshot 2025-09-23 at 10 39 33 AM" src="https://github.com/user-attachments/assets/2d88eee2-4f74-44fb-86f2-cf534c75fa58" /> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>

…es lost when dashboard updated from listing page (#241893) Closes #241891 for 9.2 branch. Fix is same as #241381 althought the root cause is different. This regression is cause by moving reference handling to the server in [links](#228511), [maps](#234806), and [legacy vis](#234249)

nreese added 4 commits September 11, 2025 12:24

[dashboards as code] move map embeddable reference handling to server

ca8aa90

clean up

ec6ec74

fix types

f9edc14

remove references from map embeddable client

8452b3e

canvas tslint

0ad0e4a

nreese added 2 commits September 11, 2025 18:46

clean up

f907ef2

fix save to library

c3f0fe1

nreese marked this pull request as ready for review September 12, 2025 16:37

nreese requested a review from a team as a code owner September 12, 2025 16:37

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Dashboards API v9.2.0 labels Sep 12, 2025

Merge branch 'main' into map_embeddable_server_refs

2db2239

ThomThomson approved these changes Sep 15, 2025

View reviewed changes

nreese merged commit 3e0efb9 into elastic:main Sep 15, 2025
12 checks passed

ThomThomson mentioned this pull request Sep 18, 2025

[Maps as code] Handle references on the server #219959

Closed

nreese mentioned this pull request Sep 22, 2025

[maps] Move reference handling to server for Maps application REST API #235990

Merged

nreese mentioned this pull request Nov 5, 2025

[dashboard][9.2] fix legacy visualize, links, and maps panel references lost when dashboard updated from listing page #241893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dashboards as code] move map embeddable reference handling to server #234806

[dashboards as code] move map embeddable reference handling to server #234806

Uh oh!

nreese commented Sep 11, 2025 •

edited

Loading

Uh oh!

nreese commented Sep 11, 2025

Uh oh!

nreese commented Sep 12, 2025

Uh oh!

nreese commented Sep 12, 2025

Uh oh!

elasticmachine commented Sep 12, 2025

API count

Uh oh!

elasticmachine commented Sep 12, 2025

Uh oh!

nreese commented Sep 15, 2025

Uh oh!

ThomThomson left a comment

Uh oh!

ThomThomson Sep 15, 2025

Uh oh!

ThomThomson Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[dashboards as code] move map embeddable reference handling to server #234806

[dashboards as code] move map embeddable reference handling to server #234806

Uh oh!

Conversation

nreese commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Sep 11, 2025

Uh oh!

nreese commented Sep 12, 2025

Uh oh!

nreese commented Sep 12, 2025

Uh oh!

elasticmachine commented Sep 12, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

elasticmachine commented Sep 12, 2025

Uh oh!

nreese commented Sep 15, 2025

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

ThomThomson Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nreese commented Sep 11, 2025 •

edited

Loading