[8.19] Hide side-nav during report generation (#234675) #234908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: elastic#227187 When we request a report we send the target element's width and use it to create a browser window. Therefore the element's width becomes the window width. When the side-nav is visible on the page, it pushes the dashboard to the right and makes it smaller. As we take only the target element's screenshot and use the width we passed as param as image width in the pdf, it becomes skewed. This PR removes the side-nav from the page during the report generation. So the dashboard uses the full window width which is the original number we passed initially. ## To verify: Add `Sample web logs` data. Change the solution view in the Space to something other than Classic. Go to `Dashboards > Sample Logs Data` and generate a PDF report. The screenshot should not be skewed. Add the below config to your kibana.yml ``` feature_flags.overrides: core.chrome.projectSideNav: 'v2' ``` Go to `Dashboards > Sample Logs Data` and generate a PDF report. The fix should be working with the new side-nav as well. (cherry picked from commit fa3bcdf) # Conflicts: # src/core/packages/chrome/browser-internal/src/ui/project/navigation.tsx # src/core/packages/chrome/browser-internal/src/ui/project/sidenav_v2/fixed_layout_sidenav.tsx
Contributor
💔 Build Failed
Failed CI Steps |
Dosant
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation