Skip to content

[8.19] Hide side-nav during report generation (#234675) #234908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

[8.19] Hide side-nav during report generation (#234675) #234908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7621d30
Hide side-nav during report generation (#234675)
ersin-erdal Sep 12, 2025
e5f8ac0
fix check types
ersin-erdal Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/core/packages/chrome/browser-internal/src/ui/project/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { EuiCollapsibleNavBeta } from '@elastic/eui';
import useObservable from 'react-use/lib/useObservable';
import type { Observable } from 'rxjs';
import { css } from '@emotion/css';
import classnames from 'classnames';

interface Props {
toggleSideNav: (isVisible: boolean) => void;
Expand All @@ -26,6 +27,14 @@ export const ProjectNavigation: FC<PropsWithChildren<Props>> = ({
toggleSideNav,
}) => {
const isCollapsed = useObservable(isSideNavCollapsed$, false);
const className = classnames(
'hide-for-sharing',
css`
.euiFlyoutBody__overflowContent {
height: 100%;
}
`
);

return (
<EuiCollapsibleNavBeta
Expand All @@ -36,11 +45,7 @@ export const ProjectNavigation: FC<PropsWithChildren<Props>> = ({
overflow: 'visible',
clipPath: `polygon(0 0, calc(var(--euiCollapsibleNavOffset) + ${PANEL_WIDTH}px) 0, calc(var(--euiCollapsibleNavOffset) + ${PANEL_WIDTH}px) 100%, 0 100%)`,
}}
className={css`
.euiFlyoutBody__overflowContent {
height: 100%;
}
`}
className={className}
>
{children}
</EuiCollapsibleNavBeta>
Expand Down