[ES|QL] Register commands onDidMount #244453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:ES|QL
bartoval
reviewed
Nov 27, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
sddonne
approved these changes
Nov 27, 2025
Contributor
sddonne
left a comment
sddonne
left a comment
There was a problem hiding this comment.
Nice! I like the new organisation
| application?: CoreStart['application']; | ||
| uiActions: ESQLEditorDeps['uiActions']; | ||
| telemetryService: ESQLEditorTelemetryService; | ||
| editor1: React.RefObject<monaco.editor.IStandaloneCodeEditor>; |
Contributor
There was a problem hiding this comment.
I know it was like this before the PR, but could we replace editor1 by editorRef?
Contributor
Author
There was a problem hiding this comment.
Good point, I will do it on a follow up to change this editor1 from all places for consistency
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Dec 1, 2025
## Summary Part of elastic#243576 Registers the custom commands only once on the didMount and disposes them on cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #243576
Registers the custom commands only once on the didMount and disposes them on cleanup