[ES|QL] Register commands onDidMount

src/platform/packages/private/kbn-esql-editor/src/custom_editor_commands.ts

@@ -0,0 +1,177 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+import { monaco } from '@kbn/monaco';
+import { ESQLVariableType, type ESQLControlVariable, QuerySource } from '@kbn/esql-types';
+import { ControlTriggerSource } from '@kbn/esql-types';
+import type { CoreStart } from '@kbn/core/public';
+import type { ESQLEditorDeps, ControlsContext } from './types';
+import type { ESQLEditorTelemetryService } from './telemetry/telemetry_service';
+
+export interface MonacoCommandDependencies {
+  application?: CoreStart['application'];
+  uiActions: ESQLEditorDeps['uiActions'];
+  telemetryService: ESQLEditorTelemetryService;
+  editor1: React.RefObject<monaco.editor.IStandaloneCodeEditor>;
+  fixedQuery: string;
+  esqlVariables?: ESQLControlVariable[];
+  controlsContext?: ControlsContext;
+  openTimePickerPopover: () => void;
+}
+
+const triggerControl = async (
+  queryString: string,
+  variableType: ESQLVariableType,
+  position: monaco.Position | null | undefined,
+  uiActions: ESQLEditorDeps['uiActions'],
+  triggerSource: ControlTriggerSource,
+  esqlVariables?: ESQLControlVariable[],
+  onSaveControl?: ControlsContext['onSaveControl'],
+  onCancelControl?: ControlsContext['onCancelControl']
+) => {
+  await uiActions.getTrigger('ESQL_CONTROL_TRIGGER').exec({
+    queryString,
+    variableType,
+    cursorPosition: position,
+    triggerSource,
+    esqlVariables,
+    onSaveControl,
+    onCancelControl,
+  });
+};
+
+export const registerCustomCommands = (deps: MonacoCommandDependencies): monaco.IDisposable[] => {
+  const {
+    application,
+    uiActions,
+    telemetryService,
+    editor1,
+    fixedQuery,
+    esqlVariables,
+    controlsContext,
+    openTimePickerPopover,
+  } = deps;
+
+  const commandDisposables: monaco.IDisposable[] = [];
+
+  // Command to redirect users to the index management page
+  commandDisposables.push(
+    monaco.editor.registerCommand('esql.policies.create', (...args) => {
+      application?.navigateToApp('management', {
+        path: 'data/index_management/enrich_policies/create',
+        openInNewTab: true,
+      });
+    })
+  );
+
+  // Choose timepicker command
+  commandDisposables.push(
+    monaco.editor.registerCommand('esql.timepicker.choose', (...args) => {
+      openTimePickerPopover();
+    })
+  );
+
+  // Accept recommended query command
+  commandDisposables.push(
+    monaco.editor.registerCommand('esql.recommendedQuery.accept', (...args) => {
+      const [, { queryLabel }] = args;
+      telemetryService.trackRecommendedQueryClicked(QuerySource.AUTOCOMPLETE, queryLabel);
+    })
+  );
+
+  // ESQL Control creation commands
+  const controlCommands = [
+    {
+      command: 'esql.control.multi_values.create',
+      variableType: ESQLVariableType.MULTI_VALUES,
+    },
+    {
+      command: 'esql.control.time_literal.create',
+      variableType: ESQLVariableType.TIME_LITERAL,
+    },
+    {
+      command: 'esql.control.fields.create',
+      variableType: ESQLVariableType.FIELDS,
+    },
+    {
+      command: 'esql.control.values.create',
+      variableType: ESQLVariableType.VALUES,
+    },
+    {
+      command: 'esql.control.functions.create',
+      variableType: ESQLVariableType.FUNCTIONS,
+    },
+  ];
+
+  controlCommands.forEach(({ command, variableType }) => {
+    commandDisposables.push(
+      monaco.editor.registerCommand(command, async (...args) => {
+        const [, { triggerSource }] = args;
+        const prefilled = triggerSource !== ControlTriggerSource.QUESTION_MARK;
+        telemetryService.trackEsqlControlFlyoutOpened(
+          prefilled,
+          variableType,
+          triggerSource,
+          fixedQuery
+        );
+        const position = editor1.current?.getPosition();
+        await triggerControl(
+          fixedQuery,
+          variableType,
+          position,
+          uiActions,
+          triggerSource,
+          esqlVariables,
+          controlsContext?.onSaveControl,
+          controlsContext?.onCancelControl
+        );
+      })
+    );
+  });
+
+  return commandDisposables;
+};
+
+export const addEditorKeyBindings = (
+  editor: monaco.editor.IStandaloneCodeEditor,
+  onQuerySubmit: (source: any) => void,
+  setIsVisorOpen: (isOpen: boolean) => void,
+  isVisorOpen: boolean
+) => {
+  // Add editor key bindings
+  editor.addCommand(
+    // eslint-disable-next-line no-bitwise
+    monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter,
+    () => onQuerySubmit(QuerySource.MANUAL)
+  );
+
+  editor.addCommand(
+    // eslint-disable-next-line no-bitwise
+    monaco.KeyMod.CtrlCmd | monaco.KeyCode.KeyK,
+    () => setIsVisorOpen(!isVisorOpen)
+  );
+};
+
+export const addTabKeybindingRules = () => {
+  // When both inline and suggestion widget are visible,
+  // we want Tab to accept inline suggestions,
+  // so we need to unbind the default suggestion widget behavior
+  monaco.editor.addKeybindingRule({
+    keybinding: monaco.KeyCode.Tab,
+    command: '-acceptSelectedSuggestion',
+    when: 'suggestWidgetHasFocusedSuggestion && suggestWidgetVisible && textInputFocus && inlineSuggestionVisible',
+  });
+
+  // Add explicit binding for Tab to accept inline suggestions when they're visible
+  monaco.editor.addKeybindingRule({
+    keybinding: monaco.KeyCode.Tab,
+    command: 'editor.action.inlineSuggest.commit',
+    when: 'inlineSuggestionVisible && textInputFocus',
+  });
+};

src/platform/packages/private/kbn-esql-editor/src/esql_editor.test.tsx

@@ -38,7 +38,7 @@ jest.mock('@kbn/monaco', () => ({
   },
 }));
 
-jest.mock('./custom_commands', () => {
+jest.mock('./lookup_join', () => {
   return {
     useCanCreateLookupIndex: jest.fn().mockReturnValue(jest.fn().mockReturnValue(true)),
     useLookupIndexCommand: jest.fn().mockReturnValue({