[Lens] Use current references for checking if data source states are the same #244700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariairiartef
added
release_note:skip
mariairiartef
added
v8.19.8
v8.19.0
v9.1.8
v9.2.2
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
reviewed
Dec 1, 2025
| previousAttrs.references, | ||
| datasourceStates[datasourceId].state, | ||
| attributes.references | ||
| datasourceMap[datasourceId].getPersistableState(datasourceStates[datasourceId].state) |
Member
There was a problem hiding this comment.
Seems to work fine, do you mind adding a comment to specify why we need to get the references from the persisted state, rather then the attributes.references?
nickofthyme
approved these changes
Dec 2, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2025
…the same (elastic#244700) ## Summary Fix elastic#234360 Uses current references for checking if data source states are the same. The fix: the "Apply and close" button is enabled when the data view is changed in the in-line editor. https://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 57a3353)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2025
…the same (elastic#244700) ## Summary Fix elastic#234360 Uses current references for checking if data source states are the same. The fix: the "Apply and close" button is enabled when the data view is changed in the in-line editor. https://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 57a3353)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2025
…the same (elastic#244700) ## Summary Fix elastic#234360 Uses current references for checking if data source states are the same. The fix: the "Apply and close" button is enabled when the data view is changed in the in-line editor. https://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 57a3353)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 3, 2025
…s are the same (#244700) (#245043) # Backport This will backport the following commits from `main` to `9.2`: - [[Lens] Use current references for checking if data source states are the same (#244700)](#244700) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-12-03T09:52:19Z","message":"[Lens] Use current references for checking if data source states are the same (#244700)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/234360\n\nUses current references for checking if data source states are the same.\n\nThe fix: the \"Apply and close\" button is enabled when the data view is\nchanged in the in-line editor.\n\n\nhttps://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"57a3353538f365f63d743d6e421cc538175cfcb5","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0","v9.2.3","v9.1.9","v8.19.9"],"title":"[Lens] Use current references for checking if data source states are the same","number":244700,"url":"https://github.com/elastic/kibana/pull/244700","mergeCommit":{"message":"[Lens] Use current references for checking if data source states are the same (#244700)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/234360\n\nUses current references for checking if data source states are the same.\n\nThe fix: the \"Apply and close\" button is enabled when the data view is\nchanged in the in-line editor.\n\n\nhttps://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"57a3353538f365f63d743d6e421cc538175cfcb5"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244700","number":244700,"mergeCommit":{"message":"[Lens] Use current references for checking if data source states are the same (#244700)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/234360\n\nUses current references for checking if data source states are the same.\n\nThe fix: the \"Apply and close\" button is enabled when the data view is\nchanged in the in-line editor.\n\n\nhttps://github.com/user-attachments/assets/6d9a100d-1c20-4184-a861-6221a53e12c5\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"57a3353538f365f63d743d6e421cc538175cfcb5"}}]}] BACKPORT--> Co-authored-by: Maria Iriarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #234360
Uses current references for checking if data source states are the same.
The fix: the "Apply and close" button is enabled when the data view is changed in the in-line editor.
Screen.Recording.2025-12-01.at.07.51.28.mov
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.