Skip to content

[Maps] Fix TS error in ESGeoGridSource by adding array check for compositeSplit buckets #244740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

[Maps] Fix TS error in ESGeoGridSource by adding array check for compositeSplit buckets #244740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0bc708
Fix TS error in ESGeoGridSource by adding array check for compositeSp…
olapawlus Dec 1, 2025
46999c7
Merge branch 'main' into fix/ts-expect-error-upgrade-TS
olapawlus Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...form/plugins/shared/maps/public/classes/sources/es_geo_grid_source/es_geo_grid_source.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@ export class ESGeoGridSource extends AbstractESAggSource implements IMvtVectorSo

const aggr = esResponse.aggregations?.compositeSplit as AggregationsCompositeAggregate;
afterKey = aggr.after_key;
// @ts-expect-error upgrade typescript v5.1.6
if (aggr.buckets.length < gridsPerRequest) {

if (Array.isArray(aggr.buckets) && aggr.buckets.length < gridsPerRequest) {
// Finished because request did not get full resultset back
break;
}
Expand Down