[Streams] Add stream type to click telemetry events in Processing #244748
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroFrndz
force-pushed
the
244133-add-stream-type-to-processing-telemetry-events
branch
2 times, most recently
from
84900b0 to
9c652b7
Compare
AlejandroFrndz
added
release_note:skip
Contributor
|
Pinging @elastic/obs-onboarding-team (Team:obs-onboarding) |
AlejandroFrndz
force-pushed
the
244133-add-stream-type-to-processing-telemetry-events
branch
from
fcb9d99 to
4cb6fa0
Compare
tonyghiani
reviewed
Dec 3, 2025
| onConfirm, | ||
| onViewCodeClick, | ||
| }: ManagementBottomBarProps) { | ||
| const streamType = useStreamEnrichmentSelector((snapshot) => selectStreamType(snapshot.context)); |
Contributor
There was a problem hiding this comment.
This makes the bar less re-usable in different pages, as it's now bound to the processing page. You should probably pass the stream type as an optional property instead of directly accessing the context for processing.
Contributor
Author
There was a problem hiding this comment.
Crap I didn't realise that was shared across processing and routing, fixing it now
Remove the exported StreamType and its import usage in the selector, letting the selector's return type be inferred instead of explicitly annotated. Cleans up an unused type, eliminates related TypeScript/linter warnings, and simplifies the typings.
Moves responsibility for deriving the stream type out of the bottom-bar component and into the stream detail enrichment parent. The bottom bar now receives streamType as a prop and no longer uses the enrichment selector/hook, while the parent selects the streamType and passes it down. This decouples the presentational bottom bar from state-machine details, improves reusability and testability, and removes unused imports.
AlejandroFrndz
force-pushed
the
244133-add-stream-type-to-processing-telemetry-events
branch
from
4cb6fa0 to
77ededd
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #244133
This PR enhances telemetry around the processing phase for streams. A new
data-stream-typeattribute has been added to all click targets involved in the process of adding, configuring and saving processing steps (conditions and processors) This enhances the telemetry events, allowing analysts to distinguish between wired and classic streams when analysing the usage of processing features.Testing
Walk through the flow to configure processing for a stream, including:
All the click targets for these events above should now include a
data-stream-typewith a value ofwiredorclassic, depending on the type of stream you're using of course.