-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[APM] Refactor mobile & profiling to use accessKnownApmEventFields #244794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Refactor mobile & profiling to use accessKnownApmEventFields #244794
Conversation
|
/ci |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💚 Build Succeeded
Metrics [docs]
History
|
| type: event[ERROR_EXC_TYPE], | ||
| }; | ||
|
|
||
| const errorName = event[ERROR_LOG_MESSAGE] || exception.message || NOT_AVAILABLE_LABEL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this in another PR. Maybe we should change the getErrorName after all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a follow-up PR after to rework getErrorName and use it in all the cases where it was removed for the new approach
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Summary
Closes #244159
This PR replaces the usage of
unflattenKnownApmEventFieldswithaccessKnownApmEventFieldsin the mobile and profiling APM routes.How to test