Skip to content

Conversation

@MiloszRadzynski
Copy link
Contributor

@MiloszRadzynski MiloszRadzynski commented Dec 3, 2025

Summary

This PR enables keyboard navigation for tabs in Discover. Users are now able to:

  • Switch between tabs using arrow keys (when the entire tab is focused).
  • Tab into the tab, and then focus the action menu and close button.
  • Open the action menu while the icon is focused, using the Space or Enter key.
  • Close the tab while the close icon is focused, using the Space or Enter key.
  • Navigate to the first/last tab using the Home and End keys.

This change also improves the screen reader output for individual tabs within the tablist. Previously, the screen reader would announce the tab with the information: ...group, 1 of 1, even when the user had multiple tabs open. Now, the screen reader should properly announce the tab's position within the tab list. (see screenshots).

Screenshots:

Before:
Screenshot 2025-12-03 at 12 05 18

After:
Screenshot 2025-12-03 at 12 06 00

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@MiloszRadzynski MiloszRadzynski self-assigned this Dec 3, 2025
@MiloszRadzynski MiloszRadzynski added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:version Backport to applied version labels v9.2.3 labels Dec 3, 2025
@MiloszRadzynski
Copy link
Contributor Author

/ci

Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, LGTM thanks!

@MiloszRadzynski MiloszRadzynski marked this pull request as ready for review December 3, 2025 13:44
@MiloszRadzynski MiloszRadzynski requested a review from a team as a code owner December 3, 2025 13:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@MiloszRadzynski MiloszRadzynski added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v9.2.3 labels Dec 3, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.3MB 1.3MB +202.0B
lens 1.6MB 1.6MB +208.0B
total +410.0B

History

cc @MiloszRadzynski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants