Skip to content

[Discover] Tabs - a11y improvements #245058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −8
Open

[Discover] Tabs - a11y improvements #245058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b817d
[Discover] Tabs - a11y improvements
MiloszRadzynski Dec 3, 2025
0801c4c
Merge branch 'main' into tabs-a11y-improvements
MiloszRadzynski Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/platform/packages/shared/kbn-unified-tabs/src/components/tab/tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ export const Tab: React.FC<TabProps> = (props) => {
item={item}
getTabMenuItems={getTabMenuItems}
isPopoverOpen={isActionPopoverOpen}
isSelected={isSelected}
setPopover={onToggleActionsMenu}
onEnterRenaming={onEnterRenaming}
/>
Expand All @@ -273,14 +274,14 @@ export const Tab: React.FC<TabProps> = (props) => {
)}
{!disableCloseButton && !!onClose && (
<EuiFlexItem grow={false} className="unifiedTabs__closeTabBtn">
<EuiToolTip content={closeButtonLabel}>
<EuiToolTip content={closeButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
// semantically role="tablist" does not allow other buttons in tabs
aria-hidden={true}
aria-label={closeButtonLabel}
color="text"
data-test-subj={`unifiedTabs_closeTabBtn_${item.id}`}
iconType="cross"
onClick={onCloseEvent}
tabIndex={isSelected ? 0 : -1}
/>
</EuiToolTip>
</EuiFlexItem>
Expand Down
9 changes: 5 additions & 4 deletions src/platform/packages/shared/kbn-unified-tabs/src/components/tab_menu/tab_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export interface TabMenuProps {
item: TabItem;
getTabMenuItems: GetTabMenuItems;
isPopoverOpen: boolean;
isSelected: boolean;
setPopover: (isOpen: boolean) => void;
onEnterRenaming: () => void;
}
Expand All @@ -33,6 +34,7 @@ export const TabMenu: React.FC<TabMenuProps> = ({
item,
getTabMenuItems,
isPopoverOpen,
isSelected,
setPopover,
onEnterRenaming,
}) => {
Expand Down Expand Up @@ -92,11 +94,10 @@ export const TabMenu: React.FC<TabMenuProps> = ({
anchorPosition="downLeft"
closePopover={closePopover}
button={
<EuiToolTip content={menuButtonLabel}>
<EuiToolTip content={menuButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
// semantically role="tablist" does not allow other buttons in tabs
aria-hidden={true}
tabIndex={-1}
aria-label={menuButtonLabel}
tabIndex={isSelected ? 0 : -1}
color="text"
data-test-subj={`unifiedTabs_tabMenuBtn_${item.id}`}
iconType="boxesVertical"
Expand Down
14 changes: 13 additions & 1 deletion src/platform/packages/shared/kbn-unified-tabs/src/components/tabs_bar/tabs_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import type { KeyboardEvent } from 'react';
import React, {
useCallback,
useEffect,
useMemo,
useRef,
useState,
forwardRef,
Expand Down Expand Up @@ -264,6 +265,11 @@ export const TabsBar = forwardRef<TabsBarApi, TabsBarProps>(
[items, selectedItem, selectAndMoveFocusToItemIndex, onClose, emitOnKeyUsedEvent]
);

const ariaOwnsValue = useMemo(
() => items.map((item) => getTabIdAttribute(item)).join(' '),
[items]
);

const mainTabsBarContent = (
<EuiFlexGroup
responsive={false}
Expand All @@ -276,7 +282,13 @@ export const TabsBar = forwardRef<TabsBarApi, TabsBarProps>(
<EuiFlexItem ref={setTabsContainerWithPlusElement} grow css={growingFlexItemCss}>
<EuiFlexGroup direction="row" gutterSize="s" alignItems="center" responsive={false}>
<EuiFlexItem grow={false} css={growingFlexItemCss}>
<div ref={setTabsContainerElement} role="tablist" css={tabsContainerCss}>
<div
aria-orientation="horizontal"
aria-owns={ariaOwnsValue}
ref={setTabsContainerElement}
role="tablist"
css={tabsContainerCss}
>
{/*
OptionalDroppable provides the drag-drop context wrapper.
When disableDragAndDrop=false, it sets up EuiDragDropContext and EuiDroppable.
Expand Down