Skip to content

[SLO] Fix back button when clicking on overview stats #245092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+4 −6
Open

[SLO] Fix back button when clicking on overview stats #245092

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff0c44e
temp
mgiota Dec 3, 2025
4e7bff5
remove replace: true
mgiota Dec 3, 2025
7f07675
cleanup
mgiota Dec 3, 2025
47df4db
Merge branch 'main' into slo-fix-back-button-overview-stats
mgiota Dec 3, 2025
c8d37b0
remove replace: false, since this is default value anyway
mgiota Dec 3, 2025
59f35ad
Merge branch 'main' into slo-fix-back-button-overview-stats
mgiota Dec 3, 2025
c3e8aa4
Merge branch 'main' into slo-fix-back-button-overview-stats
mgiota Dec 3, 2025
e67967c
Merge branch 'main' into slo-fix-back-button-overview-stats
mgiota Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/solutions/observability/plugins/slo/public/pages/slos/hooks/use_url_search_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ export function useUrlSearchState(): {
const sub = urlStateStorage.current
?.change$<SearchState>(SLO_LIST_SEARCH_URL_STORAGE_KEY)
.subscribe((newSearchState) => {
Copy link
Contributor Author

@mgiota mgiota Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty/cleared search state resets to DEFAULT_STATE.

if (newSearchState) {
setState(newSearchState);
}
// When URL has no search params, newSearchState will be null/undefined
// In that case, reset to DEFAULT_STATE
setState(newSearchState ?? DEFAULT_STATE);
});

setState(
Expand All @@ -89,7 +89,7 @@ export function useUrlSearchState(): {
setState(() => updatedState);

urlStateStorage.current?.set(SLO_LIST_SEARCH_URL_STORAGE_KEY, updatedState, {
replace: true,
replace: false,
Copy link
Contributor Author

@mgiota mgiota Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace: false creates a new browser history entry. Previously changes used replace, which blocked back/forward navigation

TODO: completely remove, since replace:false is the default value

Copy link
Contributor Author

@mgiota mgiota Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in this commit

});

// Discard search itself from session storage. Keep only view preferences
Expand Down