[SLO] Fix back button when clicking on overview stats #245092
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
author:actionable-obs
mgiota
force-pushed
the
slo-fix-back-button-overview-stats
branch
from
480de5b to
f283aa7
Compare
mgiota
added
the
Team:actionable-obs
Copilot finished reviewing on behalf of
mgiota
December 3, 2025 14:33
mgiota
force-pushed
the
slo-fix-back-button-overview-stats
branch
from
f283aa7 to
4e7bff5
Compare
mgiota
force-pushed
the
slo-fix-back-button-overview-stats
branch
4 times, most recently
from
3fa6db6 to
6ebe95b
Compare
mgiota
force-pushed
the
slo-fix-back-button-overview-stats
branch
from
6ebe95b to
7f07675
Compare
Copilot finished reviewing on behalf of
mgiota
December 3, 2025 15:32
mgiota
commented
Dec 3, 2025
|
|
||
| urlStateStorage.current?.set(SLO_LIST_SEARCH_URL_STORAGE_KEY, updatedState, { | ||
| replace: true, | ||
| replace: false, |
Contributor
Author
There was a problem hiding this comment.
replace: false creates a new browser history entry. Previously changes used replace, which blocked back/forward navigation
TODO: completely remove, since replace:false is the default value
mgiota
commented
Dec 3, 2025
| useEffect(() => { | ||
| const sub = urlStateStorage.current | ||
| ?.change$<SearchState>(SLO_LIST_SEARCH_URL_STORAGE_KEY) | ||
| .subscribe((newSearchState) => { |
Contributor
Author
There was a problem hiding this comment.
An empty/cleared search state resets to DEFAULT_STATE.
Contributor
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
mgiota
added
release_note:skip
baileycash-elastic
approved these changes
Dec 3, 2025
Contributor
baileycash-elastic
left a comment
baileycash-elastic
left a comment
There was a problem hiding this comment.
Looks good, maybe re-run FTRs for good measure?
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @mgiota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245069
Before
Screen.Recording.2025-12-03.at.14.17.40.mov
Before the fix, when clicking on the stats count and then navigating back to
/app/slos (no search params in the URL)the urlStateStorage returned null or undefined, but the subscription had a checkif newSearchStatethat prevented updating the state.After
Now when the URL changes to have no search params (when we click back), the subscription receives null/undefined for newSearchState, it sets the state to DEFAULT_STATE, Searchbar receives the empty state and remounts with cleared values
Screen.Recording.2025-12-03.at.16.08.20.mov