Convert Ruby Integer and PositiveInteger settings classes to Java #17460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
|
andsel
changed the title
andsel
force-pushed
the
feature/integers_setting_to_java
branch
from
500ee82 to
0e99a1a
Compare
|
andsel
force-pushed
the
feature/integers_setting_to_java
branch
from
0e99a1a to
7edc640
Compare
donoghuc
reviewed
Aug 8, 2025
donoghuc
requested changes
Aug 8, 2025
|
💚 Build Succeeded
History
cc @andsel |
donoghuc
approved these changes
Aug 11, 2025
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Aug 15, 2025
Recently elastic#17460 the implementation for integer/postive integer settings was moved from jruby to pure java. The ruby implementation was leinient with whitespace in string values. This commit updates the java implementation to replicate this by stripping whitespace from string values before trying to parse them as int.
donoghuc
added a commit
that referenced
this pull request
Aug 15, 2025
Recently #17460 the implementation for integer/postive integer settings was moved from jruby to pure java. The ruby implementation was leinient with whitespace in string values. This commit updates the java implementation to replicate this by stripping whitespace from string values before trying to parse them as int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Convert the Ruby settings classes Integer and PositiveInteger to Java, renaming them to SettingInteger and SettingPositiveInteger.
Why is it important/What is the impact to the user?
As a developer I want all the settings hierarchy to be implemented in a statically typed language, Java.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues