Skip to content

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented May 9, 2025

@karenzone karenzone self-assigned this May 9, 2025
@karenzone karenzone added docs backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels May 9, 2025
@elastic elastic deleted a comment from mergify bot May 9, 2025
@karenzone karenzone requested a review from colleenmcginnis May 19, 2025 22:43
@karenzone karenzone marked this pull request as ready for review May 19, 2025 22:43
@karenzone karenzone requested a review from vishaangelova May 19, 2025 22:43
Copy link
Contributor

@vishaangelova vishaangelova May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 22:

  • In {{ls}} uses the Cloud ID, found in the Elastic Cloud web console, to build the Elasticsearch and Kibana hosts settings., is it perhaps hosts’ settings?

  • There’s a missing period at the end of the last sentence + maybe remove should, and add a comma after To add a label: To add a label, prefix your Cloud ID with a label and a : separator in this format "<label>:<cloud-id>”.

This is probably out of scope, though, so not sure if it’s OK to point these out now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always OK to point things out. 😄

Copy link
Contributor

@vishaangelova vishaangelova May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, I realized what hosts refers to, so I’d ammend my comment and suggest that it probably should be:

to build the Elasticsearch and Kibana `hosts` settings

Comment on lines +49 to +50
ess-leadin-short: "Elastic Cloud Hosted is available on AWS, GCP, and Azure, and you can try it for free at https://cloud.elastic.co/registration."
ess-leadin: "You can run Elasticsearch on your own hardware or use Elastic Cloud Hosted, available on AWS, GCP, and Azure. Try Elastic Cloud Hosted for free: https://cloud.elastic.co/registration."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also change ess-leadin-short to ech-leadin-short and ess-leadin to ech-leadin here and in any Markdown files, but I don't think that's blocking.

@karenzone karenzone merged commit e76b718 into elastic:main Jun 24, 2025
7 checks passed
@karenzone karenzone deleted the 17652-cloud branch June 24, 2025 21:32
@github-actions
Copy link
Contributor

@Mergifyio backport 9.0

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2025

backport 9.0

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants