Fixes to the bundles gems and jars versions #17659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
…me duplicated gems which are already vendored to an upper version
andsel
force-pushed
the
fix/avoid_hard_pins_and_clean_dup_jars
branch
from
843f070 to
3462446
Compare
yaauie
reviewed
May 20, 2025
Comment on lines
+108
to
+109
| @exclude_paths << 'vendor/jruby/lib/ruby/stdlib/cgi{,.rb}' | ||
| @exclude_paths << 'vendor/jruby/lib/ruby/stdlib/cgi/**/*' |
There was a problem hiding this comment.
Review note:
- build a tarball:
./gradlew assembleTarDistribution - Look for instances of the word
cgi, and ensure that the stdlib entry present invendor/jruby/lib/ruby/stdlibof source is not present in the tarbal:tar -tzf build/logstash-9.1.0-SNAPSHOT.tar.gz | egrep '\cgi\b'
|
💚 Build Succeeded
History
cc @andsel |
yaauie
added
backport-8.17
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2025
* Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e)
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2025
* Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e) # Conflicts: # Gemfile.template
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2025
* Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e) # Conflicts: # rakelib/artifacts.rake
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2025
* Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e) # Conflicts: # Gemfile.template
This was referenced May 20, 2025
yaauie
added a commit
that referenced
this pull request
May 20, 2025
* Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- (cherry picked from commit 06c877e) Co-authored-by: Andrea Selva <[email protected]> Co-authored-by: Ry Biesemeyer <[email protected]>
yaauie
added a commit
that referenced
this pull request
May 20, 2025
…17664) * Fixes to the bundles gems and jars versions (#17659) * Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e) # Conflicts: # Gemfile.template * fix merge conflict (line order) --------- Co-authored-by: Andrea Selva <[email protected]> Co-authored-by: Rye Biesemeyer <[email protected]>
yaauie
added a commit
that referenced
this pull request
May 20, 2025
…17662) * Fixes to the bundles gems and jars versions (#17659) * Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version * exclude inactive net-imap-0.2.3 from artifacts * artifacts: exclude "default" stdlib gems that are shadowed by pinned gems --------- Co-authored-by: Ry Biesemeyer <[email protected]> (cherry picked from commit 06c877e) # Conflicts: # Gemfile.template * fix conflict (line order) --------- Co-authored-by: Andrea Selva <[email protected]> Co-authored-by: Rye Biesemeyer <[email protected]>
andsel
added a commit
that referenced
this pull request
May 21, 2025
…17663) Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version --------- Co-authored-by: Andrea Selva <[email protected]> Co-authored-by: Rye Biesemeyer <[email protected]>
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Avoid hard pins on gem versions in the Gemfile.template and remove some duplicated gems which are already vendored to an upper version