Move Port and PortRange Ruby settings to Java #17964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
…od eachWithIndex to Range to loop on the interval
…ructor can coerce on values offered for default value. Fixed failing test trasforming Ruby rage to newly introduced Java Range class
andsel
force-pushed
the
feature/portrange_setting_to_java
branch
from
15bb6a5 to
8ba2530
Compare
…d ability to accept also JRuby's RubyRange instances
…oid the creation of Java Range class
andsel
changed the title
jsvd
reviewed
Sep 16, 2025
logstash-core/src/main/java/org/logstash/settings/SettingPortRange.java
Outdated
Show resolved
Hide resolved
jsvd
approved these changes
Sep 16, 2025
Co-authored-by: João Duarte <[email protected]>
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @andsel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Move the existing Ruby code to Port and PortRange classes to Java, leveraging the JRuby bridge and avoiding to use the JRuby extension mechanism.
Why is it important/What is the impact to the user?
Aa a developer I want the core code base to be in Java and avoiding leveraging on Ruby classes and extension classes as much as possible.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs