Start all exhastive tests in parallel #17978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
donoghuc
added
the
backport-active-all
|
Exhastive test run https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2304 |
|
💚 Build Succeeded
|
|
Looks like the test run finished in less than an hour, confirming that the synchonized start will cut down on total time https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2304#0198a5bc-aea6-4c03-b2f5-182789ca30ad |
|
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py
This was referenced Aug 14, 2025
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d)
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py
This was referenced Aug 14, 2025
donoghuc
added a commit
that referenced
this pull request
Aug 14, 2025
* Start all exhastive tests in parallel (#17978) Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Aug 14, 2025
* Start all exhastive tests in parallel (#17978) Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Aug 14, 2025
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Aug 14, 2025
* Start all exhastive tests in parallel (#17978) Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Aug 14, 2025
* Start all exhastive tests in parallel (#17978) Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline.
Related issues