Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 14, 2025

Release notes

[rn:skip]

What does this PR do?

Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline.

Related issues

Previously the package based tests would be blocked on the pull request suite.
Given those tests MUST have be run to even get code in to a branch this results
in the exhaustive test suite taking roughly 30 mins to even start the unique
tests. In practice when we want to reproduce or test a failure in the exhaustive
suite we DONT want to be blocked on seeing the PR tests. This commit removes the
depends-on condition for the package based tests on the pull request tests. It
does not seem like any protection from doing unncessary package based tests if a
pull request test fails is worth the extra wall time in practice. This should
significantly decrease the total time needed for the exhaustive test pipeline.

(cherry picked from commit 332355d)

# Conflicts:
#	.buildkite/scripts/exhaustive-tests/generate-steps.py
@mergify mergify bot added backport conflicts Detected git conflicts labels Aug 14, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Aug 14, 2025

Cherry-pick of 332355d has failed:

On branch mergify/bp/9.0/pr-17978
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit 332355d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/scripts/exhaustive-tests/generate-steps.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@donoghuc donoghuc merged commit c025d94 into 9.0 Aug 14, 2025
10 of 11 checks passed
@donoghuc donoghuc deleted the mergify/bp/9.0/pr-17978 branch August 14, 2025 19:05
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @donoghuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts Detected git conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants