Skip to content

Global configuration flag for media previews #29582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Apr 22, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Mar 24, 2025

This implements MSC4155
Figma

This feature adds support for an account-level setting for configuring your own safety levels when browsing rooms. We already have support for configuring media previews on a per-device level but this allows the configuration to be expressed cross-device / client.

While not explicitly implemented, this also allows for servers to express defaults for their users (by setting default account data, if the server supports it).

Global setting

image

Room setting

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@amshakal
Copy link

Looks fine to me but the spacing seems a bit off between:

  1. The title and subheading in 'Show media in timeline' section
  2. The spacing between different radio button options

@Half-Shot
Copy link
Member Author

Looks fine to me but the spacing seems a bit off between:

1. The title and subheading in 'Show media in timeline' section

2. The spacing between different radio button options

image

How's this @amshakal ?

@amshakal
Copy link

That's better! :) TY!

@Half-Shot Half-Shot added this pull request to the merge queue Apr 22, 2025
Merged via the queue into develop with commit 75d9898 Apr 22, 2025
34 checks passed
@Half-Shot Half-Shot deleted the hs/media-previews-server-config branch April 22, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants