Skip to content

Conversation

@NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 6, 2025

This is not ready for merge, and just for demonstration right now.

If folks have eliminated their hbs, they can have a far superior TS experience by doing the changes in this PR to their app.

Why can't we merge this?

Glint V2 does not support hbs, and the current iteration of the app blueprint must support hbs.

More on this later.

"@glint/environment-ember-template-imports": "^1.5.2",
"@glint/template": "^1.5.2<% } %>",
"@glint/ember-tsc": "^1.0.0",
"@glint/template": "^1.6.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devDeps is correct tho

Copy link

@urbany urbany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove ember-template-lint since hbs is no longer supported?

@NullVoxPopuli
Copy link
Contributor Author

Nay, we still use it for the template blocks in a gjs/gts file.

There is an effort to port over all the lints from template to the eslint plugin, tho. When that finishes (want to help? <3) we can remove template-lint

@urbany
Copy link

urbany commented Oct 10, 2025

@NullVoxPopuli ah ok, and these lines still make sense? will they lint the gj and gts files?

    "lint:hbs": "ember-template-lint .",
    "lint:hbs:fix": "ember-template-lint . --fix",

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Oct 10, 2025

ye

there is an even option you can set in the templatelint config to disable checking of js/ts (like, old-style tests with hbs)

'use strict';
module.exports = {
  extends: 'recommended',
  checkHbsTemplateLiterals: false,
};

this isn't required and is only a minor perf improvement for template-lint speed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants