-
-
Notifications
You must be signed in to change notification settings - Fork 8
Glint v2 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Glint v2 #90
Conversation
| "@glint/environment-ember-template-imports": "^1.5.2", | ||
| "@glint/template": "^1.5.2<% } %>", | ||
| "@glint/ember-tsc": "^1.0.0", | ||
| "@glint/template": "^1.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs say this needs to be under deps not devDeps
https://github.com/typed-ember/glint/blob/main/docs/v2-upgrade.md#step-2-upgrade-glinttemplate-to-the-latest-npm-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devDeps is correct tho
urbany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove ember-template-lint since hbs is no longer supported?
|
Nay, we still use it for the There is an effort to port over all the lints from template to the eslint plugin, tho. When that finishes (want to help? <3) we can remove template-lint |
|
@NullVoxPopuli ah ok, and these lines still make sense? will they lint the gj and gts files? "lint:hbs": "ember-template-lint .",
"lint:hbs:fix": "ember-template-lint . --fix", |
|
ye there is an even option you can set in the templatelint config to disable checking of js/ts (like, old-style tests with hbs) 'use strict';
module.exports = {
extends: 'recommended',
checkHbsTemplateLiterals: false,
};this isn't required and is only a minor perf improvement for template-lint speed |
This is not ready for merge, and just for demonstration right now.
If folks have eliminated their hbs, they can have a far superior TS experience by doing the changes in this PR to their app.
Why can't we merge this?
Glint V2 does not support hbs, and the current iteration of the app blueprint must support hbs.
More on this later.