Skip to content

Glint v2 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Glint v2 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"lint:hbs:fix": "ember-template-lint . --fix",
"lint:js": "eslint . --cache",
"lint:js:fix": "eslint . --fix<% if (typescript) { %>",
"lint:types": "glint<% } %>",
"lint:types": "ember-tsc<% } %>",
"start": "vite",
"test": "vite build --mode development && testem ci"
},
Expand Down Expand Up @@ -58,10 +58,9 @@
"@embroider/config-meta-loader": "^1.0.0",
"@eslint/js": "^9.34.0",
"@glimmer/component": "^2.0.0<% if (typescript) { %>",
"@glint/core": "^1.5.2",
"@glint/environment-ember-loose": "^1.5.2",
"@glint/environment-ember-template-imports": "^1.5.2",
"@glint/template": "^1.5.2<% } %>",
"@glint/ember-tsc": "^1.0.0",
"@glint/template": "^1.6.1",
Copy link
Contributor

@void-mAlex void-mAlex Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs say this needs to be under deps not devDeps
https://github.com/typed-ember/glint/blob/main/docs/v2-upgrade.md#step-2-upgrade-glinttemplate-to-the-latest-npm-version

Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devDeps is correct tho

"@glint/tsserver-plugin": "^2.0.3<% } %>",
"@rollup/plugin-babel": "^6.0.4<% if (typescript) { %>",
"@types/qunit": "^2.19.13",
"@types/rsvp": "^4.0.9<% if (emberData) {%>",
Expand Down
5 changes: 1 addition & 4 deletions files/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
{
"extends": "@ember/app-tsconfig",
"include": ["app", "tests", "types"],
"glint": {
"environment": ["ember-loose", "ember-template-imports"]
},
"compilerOptions": {
"allowJs": true,
"paths": {
"<%= name %>/tests/*": ["./tests/*"],
"<%= name %>/*": ["./app/*"],
"*": ["./types/*"]
},
"types": ["ember-source/types", "@embroider/core/virtual", "vite/client"]
"types": ["ember-source/types", "@embroider/core/virtual", "vite/client", "@glint/ember-tsc/types"]
}
}
Loading