WIP Use ember-mobile-menu for mobile nav #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm skipping tests on this one because we're going to be implementing a new template for ember-learn/rfcs-app#8 and it's not really worth putting too much effort into this template when it's going to be essentially "thrown away" |
ember-learn/rfcs-app#5 Co-authored-by: Chris Manson <[email protected]>
mansona
force-pushed
the
jw-cm-menu-rfcs-app-5
branch
from
8177eed
to
c4ae4da
Compare
mansona
requested changes
Jul 14, 2022
| @@ -56,6 +56,7 @@ | |||
| "ember-fetch": "^8.1.1", | |||
| "ember-load-initializers": "^2.1.2", | |||
| "ember-maybe-import-regenerator": "^0.1.6", | |||
| "ember-mobile-menu": "^2.1.1", | |||
There was a problem hiding this comment.
actually turns out this needs to be a dependency 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile menu is rendering and working, hides on desktop. Remaining to do:
fixes: ember-learn/rfcs-app#5
Co-authored-by: Chris Manson [email protected]