Make Native Image opt-out

[hubertp]

Pull Request Description

This change makes Native Image build opt-out rather than opt-in. To use JVM mode, IDE has to start with --jvm or ENSO_LAUNCHER=shell.

An alternative approach to #12501. Closes #12483.
Likely also addresses #12303.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.

[JaroslavTulach]

• ENSO_LAUNCHER would be a new user facing API
• it has to be documented
• meaning of ENSO_JVM_OPTS and ENSO_LAUNCHER combination is not clear
• such a combination has to be documented/tested should ENSO_LAUNCHER environment variable really become support API for the next release

[JaroslavTulach]

According to @jdunkerley some users are using ENSO_JVM_OPTS already:

• this PR would break their workflows
  • very likely the project-manager would not be able to invoke the engine at all
  • failing with uncomprehensible failure
• it changes the meaning of ENSO_JVM_OPTS
• contary to Use NI mode by default unless an env variable is set #12501 which
  • attempts to keep compatiblity
  • keeps meaning of ENSO_JVM_OPTS unchanged

[hubertp]

I agree that ENSO_LAUNCHER is not the best way. Since the other PR got no-merge, I will update this PR so that project-manager/IDE accepts --jvm instead. That should be fairly non-controversial and easy to add.

[JaroslavTulach]

As the one who argued in favor of --jvm in the past, I shall support the project-manager --jvm approach....

I will update this PR so that project-manager/IDE accepts --jvm instead. That should be fairly non-controversial and easy to add.

...and I will!

• project-manager --jvm option is consistent with enso --jvm
• we wanted such a consistency and we still want it - e.g. it seems like a good solution
• --jvm focuses on the core issues of today: opt-out from native image mode
• we leave the memory settings & co. options for power users via ENSO_JVM_OPTS for now

One question:

• how does one pass --jvm option to AppImage?

[hubertp]

• how does one pass --jvm option to AppImage?

I'm already on it.

[github-actions]

🧪 Storybook is successfully deployed!

📊 Dashboard:

• 👀 Review changes: https://www.chromatic.com/build?appId=673738989fc3e8430364197e&number=1866
• 👨‍🎨 Preview storybook: https://673738989fc3e8430364197e-lvnobgfwop.chromatic.com/

[JaroslavTulach]

• I like how the PR is shaping with --jvm argument
• I still believe context.rs change shouldn't be part of this PR

[hubertp]

Ready for review, folks.

[JaroslavTulach]

With 05329f9 it all seems fine to me.

[somebody1234]

approving changes in app/ide-desktop

[4e6]

Forgot to cleanup or

Suggested change

	val GENERATING_INDEX_TIMEOUT = 60 * 4 // 2 minutes
	val GENERATING_INDEX_TIMEOUT = 60 * 4 // 4 minutes

[4e6]

in ideal world

scala> {
     | import scala.concurrent.duration._
     | 4.minutes.toSeconds
     | }
val res4: Long = 240

[hubertp]

Good catch, I will add it to next PR. Didn't want to trigger yet another build, it would take ages and this needed to get it to nightly.