Skip to content

Make Native Image opt-out #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 17, 2025
Merged

Make Native Image opt-out #12515

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfe1d42
Make Native Image opt-out
hubertp Mar 16, 2025
c42ad6e
Pass around `--jvm` flag in PM/LS
hubertp Mar 17, 2025
77178f9
Allow for `--jvm` flag in AppImage
hubertp Mar 17, 2025
14e9e94
changelog update
hubertp Mar 17, 2025
8caf5ec
linter
hubertp Mar 17, 2025
ac7330c
Unbreak build
hubertp Mar 17, 2025
b370d4c
nits
hubertp Mar 17, 2025
05329f9
Disable building NI for non-releases
hubertp Mar 17, 2025
76ebb77
fix tests
hubertp Mar 17, 2025
ffdc88a
Update docs/infrastructure/native-image.md
hubertp Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/ide-desktop/client/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ export const CONFIG = contentConfig.OPTIONS.merge(
value: true,
description: 'Start the engine process.',
}),
jvm: new contentConfig.Option({
passToWebApplication: false,
value: false,
description: 'Start engine in JVM mode.',
}),
inspect: new contentConfig.Option({
passToWebApplication: false,
primary: false,
Expand Down
4 changes: 3 additions & 1 deletion app/ide-desktop/client/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,9 @@ class App {
this.args.groups.debug.options.profile.value ?
['--profiling-path', 'profiling.npss', ...backendProfileTime]
: []
const backendOpts = [...backendVerboseOpts, ...backendProfileOpts]
const backendJvmOpts =
this.args.options.jvm.value ? ['--jvm'] : []
const backendOpts = [...backendVerboseOpts, ...backendProfileOpts, ...backendJvmOpts]
const backendEnv = Object.assign({}, process.env, {
SERVER_HOST: this.projectManagerHost,
SERVER_PORT: `${this.projectManagerPort}`,
Expand Down
Loading