Stories rework: VaDropdown #4044
Conversation
packages/ui/src/components/va-aspect-ratio/VaAspectRatio.stories.ts
Outdated
Show resolved
Hide resolved
| keepAnchorWidth | ||
| > | ||
| <template #anchor> | ||
| <div> |
| components: { VaDropdown, VaValue, VaDropdownContent }, | ||
| template: ` | ||
| <VaValue #default="v" :default-value="true"> | ||
| <button @click="v.value = !v.value">{{ v.value ? 'Short' : 'Long' }}</button> |
There was a problem hiding this comment.
No switches without big need.
Just use 2 examples in one story.
| `, | ||
| }) | ||
|
|
||
| export const Cursor = () => ({ |
There was a problem hiding this comment.
Trigger? Has nothing to do with cursor.
See border implementation for good examples on how to implement this
http://localhost:6006/?path=/story/vaalert--border
notice default prop is not set in story - allows us to catch default regressions.
There was a problem hiding this comment.
How border relates to this? Didn't get it
| `, | ||
| }) | ||
|
|
||
| export const AnchorBoundProps = () => ({ |
There was a problem hiding this comment.
| export const AnchorBoundProps = () => ({ | |
| export const AnchorSlotProps = () => ({ |
| <div style="height: 1000px"> | ||
| <va-dropdown> | ||
| <template #anchor> | ||
| <va-button>Anchor</va-button> |
There was a problem hiding this comment.
let's either use va-button everywhere or nowhere
| `, | ||
| }) | ||
|
|
||
| export const Autoplacement: StoryFn = () => ({ |
There was a problem hiding this comment.
Need an example for default autoplacement behavior.
It's not clear to me how using autoplacementTargetRef differs from not using it.
There was a problem hiding this comment.
Default autoplacement behaviour without target doesn't seem to handle overflow properly and dropdown gets positioned outside of scroll parent. Is this needed to be showcased? I thought that in this case target needs to be specified for everything to work correctly and I doubt that improper usage should be shown
There was a problem hiding this comment.
Or is current behaviour without specifying the target considered a bug?
Fsss126
force-pushed
the
stories-rework-va-dropdown
branch
from
c9f8f2e to
f9aa185
Compare
See #3676.
Types of changes