Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories rework: VaDropdown #4044

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Stories rework: VaDropdown #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc1fe71
refactor(storybook): Rework VaDropdown stories (#3676)
Fsss126 Nov 28, 2023
4e857c0
refactor(storybook): Review touches for VaAspectRatio.stories.ts (#3676)
Fsss126 Nov 29, 2023
f9aa185
refactor(storybook): Review touches for VaDropdown.stories.ts (#3676)
Fsss126 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions packages/ui/src/components/va-aspect-ratio/VaAspectRatio.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export default {
export const Default = () => ({
components: { VaAspectRatio },
template: `
<va-aspect-ratio
:style="{ width: '200px', border: '1px solid black' }"
<va-aspect-ratio
class="w-48 border-dashed border-2"
:ratio="1/1"
>
Content
Expand All @@ -22,15 +22,15 @@ export const Ratio = () => ({
components: { VaAspectRatio },
template: `
[1/1]
<va-aspect-ratio
:style="{ width: '200px', border: '1px solid black' }"
<va-aspect-ratio
class="w-48 border-dashed border-2"
:ratio="1/1"
>
Content
</va-aspect-ratio>
[16/9]
<va-aspect-ratio
:style="{ width: '200px', border: '1px solid black' }"
<va-aspect-ratio
class="w-48 border-dashed border-2"
:ratio="16/9"
>
Content
Expand All @@ -42,16 +42,16 @@ export const contentHeightAndWidth = () => ({
components: { VaAspectRatio },
template: `
[200/200]
<va-aspect-ratio
:style="{ width: '200px', border: '1px solid black' }"
<va-aspect-ratio
class="w-48 border-dashed border-2"
:content-width="200"
:content-height="200"
>
Content
</va-aspect-ratio>
[1280/720]
<va-aspect-ratio
:style="{ width: '200px', border: '1px solid black' }"
<va-aspect-ratio
class="w-48 border-dashed border-2"
:content-width="1280"
:content-height="720"
>
Expand All @@ -63,21 +63,13 @@ export const contentHeightAndWidth = () => ({
export const maxWidth = () => ({
components: { VaAspectRatio },
template: `
[200]
<va-aspect-ratio
:style="{ width: '500px', border: '1px solid black' }"
<va-aspect-ratio
class="border-dashed border-2"
style="width: 500px"
:max-width="200"
:ratio="16/9"
>
Content
</va-aspect-ratio>
[500]
<va-aspect-ratio
:style="{ width: '500px', border: '1px solid black' }"
:max-width="500"
:ratio="16/9"
>
Content
Max width 200px
</va-aspect-ratio>
`,
})
Loading
Loading