-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate infections #557
Simulate infections #557
Conversation
93a6b3e
to
45204f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Seb. Neat enhancement. I've left a few non-earth-shattering comments.
32b5dc8
to
502be82
Compare
Thanks, @jamesmbaazam. Added your suggestions and a few tests which revealed few minor issues in the stan code which have now been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an overall functionality perspective this looks good to me. One note about a testing gap that is somewhat optional.
I think wait for @jamesmbaazam to be happy with the software dev side and then merge.
545fb3c
to
c25de34
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8eb1b5d is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Seb. LGTM.
Co-authored-by: James Azam <[email protected]>
Co-authored-by: James Azam <[email protected]>
Co-authored-by: James Azam <[email protected]>
a4713ec
to
9bf0212
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3c1ad81 is merged into main:
|
Description
This PR closes #509
It re-introduces the
simulate_infections
function, this time to simulate from given parameters (at the minimum, a trajectory of R and the number of initial infections). It also adds truncation to the simulation model (which had been missing).Doing so required a small change to
extract_parameter_samples
which won't affect any existing functionality.Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request