-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #219
Conversation
4425a54
to
ce85ead
Compare
Some changes needs to be made to the rules of this plugin:
|
@MichaelDeBoey Can you fix the problems? Thanks |
ce85ead
to
3e34ab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-akait I'm not sure if these schemas are correct.
Please check them out.
ecea959
to
6d6d4cf
Compare
why do dev dependencies need to be compatible? you can still use v7 for lining this, right? |
Hi there, I need this peerDeps change to update eslint with npm@8. eslint-plugin-node seems to support eslint 5+. https://github.com/mysticatea/eslint-plugin-node/blob/master/package.json#L12-L14 So I suppose eslint-plugin-promise doesn't need to wait to update it. What is your concern about? @MichaelDeBoey |
It is essentially broken at the moment. Waiting for the following PR to get merged: eslint-community/eslint-plugin-promise#219
@xjamundx what can we do to help to get this merged? |
6756f7d
to
c57e930
Compare
@xjamundx I thinks PR’s that @MichaelDeBoey created are good enough to review as opposed to one large PR. This will make updating to latest ESLint easier. |
Ping @xjamundx |
okay let me take a look at everything this weekend. would love to get this published soon |
@xjamundx if you need any help, you can always ping me 😉 |
c57e930
to
5e5a4e0
Compare
5e5a4e0
to
86d81ee
Compare
@xjamundx This one can be merged now |
@xjamundx Thanks for taking the time to merge this! If you're publishing a new version, be sure to make it a major, as we've dropped Node 10 |
Give me a bit but yes we'll get it published soon. Fh
…On Fri, Dec 17, 2021, 4:55 PM Michaël De Boey ***@***.***> wrote:
@xjamundx <https://github.com/xjamundx> Thanks for taking the time to
merge this!
If you're publishing a new version, be sure to make it a major, as we've
dropped Node 10
—
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4C735PTM3CGVEFQ4MZ7TURPLZPANCNFSM5FXASWZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
eslint-config-prettier
(Support ESLint 8.x prettier/eslint-config-prettier#200)Releaseeslint-plugin-eslint-plugin
(Support ESLint 8.x eslint-plugin-eslint-plugin#175)meta.hasSuggestions
property tometa-property-ordering
rule eslint-plugin-eslint-plugin#119v4.0.0-0
v4.0.0
eslint-plugin-jest
(Support ESLint 8.x jest-community/eslint-plugin-jest#881)hasSuggestion
for ESLint v8 jest-community/eslint-plugin-jest#898hasSuggestions
rather thanhasSuggestion
jest-community/eslint-plugin-jest#899eslint@8
jest-community/eslint-plugin-jest#940@typescript-eslint/experimental-utils
to v5 jest-community/eslint-plugin-jest#941@typescript-eslint/eslint-plugin@5
jest-community/eslint-plugin-jest#942v24.4.1
v24.4.2
v25.0.0
v25.0.4
v25.0.5
v25.1.0
eslint-plugin-node
(Support ESLint 8.x mysticatea/eslint-plugin-node#294)eslint-plugin-prettier
(Support ESLint 8.x prettier/eslint-plugin-prettier#427)Releasejest-runner-eslint
(Support ESLint 8.x jest-community/jest-runner-eslint#122)ESLint
instead ofCLIEngine
when available jest-community/jest-runner-eslint#128v0.11.0
v1.0.0
Closes #218