-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] force shellws failure by adding tabs #19049
Conversation
Signed-off-by: Ivan Valdes <[email protected]>
Skipping CI for Draft Pull Request. |
/test pull-etcd-verify |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #19049 +/- ##
==========================================
+ Coverage 68.75% 68.77% +0.01%
==========================================
Files 420 420
Lines 35623 35623
==========================================
+ Hits 24493 24499 +6
+ Misses 9709 9699 -10
- Partials 1421 1425 +4 Continue to review full report in Codecov by Sentry.
|
/test pull-etcd-verify |
Originally this was intended to be a clean up. But after further investigation the original code didn't work. It didn't detect tabs in shell scripts. Signed-off-by: Ivan Valdes <[email protected]>
d4e2679
to
2656121
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-etcd-verify |
@ivanvc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.