Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ROS2 build in CI and fix any errors #32

Merged
merged 16 commits into from
Dec 8, 2023

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Dec 6, 2023

Extends #30 by adding working CI. As part of this PR (I could split off if needed), I did the following:

CI Changes

  • Run on Gitlab's public runners instead of self hosted. Without this, people forking the repo would have the actions hang forever.
  • CI runs colcon build and colcon test

Other changes necessary to get CI to pass

  • All rosdep dependencies are resolving correctly, and none are missing for compilation success
  • Remove unused rosdep keys and packages
  • Add in fixes for Ubuntu packaging errors on GeographicLib
  • Remove the custom cmake scripts for GeographicLib datasets (perhaps these are still needed?)

Jaeyoung-Lim and others added 15 commits December 4, 2023 19:27
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
* Rely on upstream to work properly

Signed-off-by: Ryan Friedman <[email protected]>
terrain-navigation.repos Outdated Show resolved Hide resolved
@Jaeyoung-Lim Jaeyoung-Lim merged commit a43c745 into ethz-asl:ros2 Dec 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants