Skip to content

Commit

Permalink
See if previous fix allows us to run all sanitizers on Ubuntu 22.04
Browse files Browse the repository at this point in the history
  • Loading branch information
victorreijgwart committed Sep 16, 2024
1 parent 450d9ae commit 49879f8
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,13 @@ jobs:
sanitize:
name: Sanitize ${{ matrix.sanitizer.detects }}
needs: test
runs-on: ${{ matrix.sanitizer.os }}
runs-on: ubuntu-22.04
strategy:
matrix:
sanitizer:
- { name: UBSAN, detects: 'undefined behavior', os: ubuntu-20.04 }
- { name: ASAN, detects: 'addressability and leaks', os: ubuntu-20.04 }
- { name: TSAN, detects: 'data races and deadlocks', os: ubuntu-22.04 }
# NOTE: We run TSAN on Ubuntu 22.04 since it's broken on 20.04, see:
# https://bugs.launchpad.net/ubuntu/+source/gcc-10/+bug/2029910.
- { name: UBSAN, detects: 'undefined behavior' }
- { name: ASAN, detects: 'addressability and leaks' }
- { name: TSAN, detects: 'data races and deadlocks' }
# NOTE: MSAN is not used for now since it also requires all deps to be
# instrumented (recompiled with clang and the MSan flags, LLVM's
# stdlib instead of GCCs,...). We therefore use Valgrind to
Expand All @@ -199,7 +197,7 @@ jobs:
- name: Setup ccache
uses: hendrikmuhs/[email protected]
with:
key: ${{ secrets.CCACHE_CACHE_VERSION }}|${{ matrix.sanitizer.os }}-gcc-${{ matrix.sanitizer.name }}
key: ${{ secrets.CCACHE_CACHE_VERSION }}|ubuntu-22.04-gcc-${{ matrix.sanitizer.name }}
create-symlink: true

- name: Setup GTest
Expand Down

0 comments on commit 49879f8

Please sign in to comment.