Feature TOS

[falkecarlsen]

Resolves #301.

Should be expanded/checked to strictly adhere to GDPR.
I'm unsure as to the phrase "By continuing to use x you agree to y" is strictly legal but we are in a predicament as our current 4463 members have not agreed to this TOS, so we need an onboarding procedure with a active choice (the active choice being the legal requirement afair).
In future, when #297 is finalised and merged, we can do a simple required-true checkbox at signup for this TOS, to ensure acceptance for all further members.

[atjn]

I have written a few corporate GDPR compliance reports and can confirm that "By continuing to use x you agree to y" is legally valid in the same way that HTML is a programming language.

[falkecarlsen]

Then we might want to do an on-boarding process for existing members, e.g. a pop-up when non-TOS member tries to do a purchase. Spamming all members with accept-requests might not be what we want to do.

[atjn]

Then we might want to do an on-boarding process for existing members, e.g. a pop-up when non-TOS member tries to do a purchase.

That is the only correct way to do it. Although you can discuss if it is really necessary for this situation.

You also have to consider that if you want to update the TOS, you need a way to inform all existing users that it has been updated. An update does not require active consent from users, as long as you are reasonably sure that they saw the message about the updated TOS.
You could develop this notification feature now, and use it to inform existing users that you are updating the TOS from version -1.0 lol to version 1.0. It isn't as good legally as the active consent that you mention above, but I doubt anyone would be mad about this approach.

[Nielswps]

Is it too much to add a column in the members table for toc_accepted (possibly with a timestamp, naming it toc_accepted_at instead)? Then all users that have not actively accepted the TOC could be prompted before any actions are completed (the timestamp would allow us to check whether they have seen/passively accepted the updated TOC).

[krestenlaust]

LGTM IANAL

[codecov]

Codecov Report

Merging #319 (740494d) into next (4c9a790) will not change coverage.
The diff coverage is n/a.

❗ Current head 740494d differs from pull request most recent head f6122fb. Consider uploading reports for the commit f6122fb to get more accurate results

@@           Coverage Diff           @@
##             next     #319   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          33       33           
  Lines        4544     4544           
  Branches      267      267           
=======================================
  Hits         2431     2431           
  Misses       2063     2063           
  Partials       50       50