Add getters for camera parameters #1419

[Dtsitos]

Describe your changes

This PR adds read-only getters to the camera API to retrieve derived world-space
camera parameters (azimuth, elevation, and distance).

The values are computed from the camera position and focal point and do not
modify camera state. This enables external applications and bindings to query
camera orientation consistently without duplicating math.

No existing behavior is changed.

Original PR: #2724

Issue ticket number and link if any

Fixes #1419

Checklist for finalizing the PR

• I have performed a self-review of my code
• I have added tests for new features and bugfixes
• I have added documentation for new features
• If it is a modifying the libf3d API, I have updated bindings
• If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

[github-actions]

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

[Dtsitos]

I think this should be correct now, will work on better testing ASAP

[snoyer]

Once you've got the tests you can double check if this is actually needed

[mwestphal]

so, is it needed @Dtsitos ?

[mwestphal]

please let us know when its ready for review @Dtsitos

[Dtsitos]

@mwestphal Hello there, I have implemented all the bindings and some basic testing for them. Full disclosure, I have never worked with bindings again and mostly deduced what to do based on the patterns from the existing implementations. Thank you for your patience

[mwestphal]

@mwestphal Hello there, I have implemented all the bindings and some basic testing for them. Full disclosure, I have never worked with bindings again and mostly deduced what to do based on the patterns from the existing implementations. Thank you for your patience

Thats perfectly fine and it looks good to me :)

[mwestphal]

@Dtsitos can you adress and resolve the suggestions made by @snoyer above ?
If you did adress them already, please resolve the discussions.

[mwestphal]

\ci full

[github-actions]

Style Checks CI failed:

diff --git a/library/src/camera_impl.cxx b/library/src/camera_impl.cxx
index 7db2c14..a7ac8cd 100644
--- a/library/src/camera_impl.cxx
+++ b/library/src/camera_impl.cxx
@@ -7,7 +7,6 @@
 #include <vtkRenderer.h>
 #include <vtkVersion.h>
 
-
 namespace f3d::detail
 {
 class camera_impl::internals
@@ -145,7 +144,6 @@ double camera_impl::getWorldAzimuth() const
   double angleRad = vtkMath::SignedAngleBetweenVectors(right, horizontal.data(), up);
 
   return vtkMath::DegreesFromRadians(angleRad);
-
 }
 
 //----------------------------------------------------------------------------
diff --git a/library/testing/TestSDKCamera.cxx b/library/testing/TestSDKCamera.cxx
index 8bc6885..6fbfda4 100644
--- a/library/testing/TestSDKCamera.cxx
+++ b/library/testing/TestSDKCamera.cxx
@@ -243,8 +243,8 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
 
   if (!compareDouble(elevation, 0.0))
   {
-    std::cerr << "getWorldElevation (horizontal) is not behaving as expected: "
-              << elevation << "\n";
+    std::cerr << "getWorldElevation (horizontal) is not behaving as expected: " << elevation
+              << "\n";
     return EXIT_FAILURE;
   }
 
@@ -259,22 +259,22 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
 
   if (!compareDouble(distance, std::sqrt(11.0 * 11.0 + 11.0 * 11.0)))
   {
-    std::cerr << "getDistance (positive elevation) is not behaving as expected: "
-              << distance << "\n";
+    std::cerr << "getDistance (positive elevation) is not behaving as expected: " << distance
+              << "\n";
     return EXIT_FAILURE;
   }
 
   if (!compareDouble(azimuth, 0.0))
   {
-    std::cerr << "getWorldAzimuth (positive elevation) is not behaving as expected: "
-              << azimuth << "\n";
+    std::cerr << "getWorldAzimuth (positive elevation) is not behaving as expected: " << azimuth
+              << "\n";
     return EXIT_FAILURE;
   }
 
   if (!compareDouble(elevation, 45.0))
   {
-    std::cerr << "getWorldElevation (positive elevation) is not behaving as expected: "
-              << elevation << "\n";
+    std::cerr << "getWorldElevation (positive elevation) is not behaving as expected: " << elevation
+              << "\n";
     return EXIT_FAILURE;
   }
 
@@ -289,15 +289,15 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
 
   if (!compareDouble(distance, std::sqrt(11.0 * 11.0 + 11.0 * 11.0)))
   {
-    std::cerr << "getDistance (negative elevation) is not behaving as expected: "
-              << distance << "\n";
+    std::cerr << "getDistance (negative elevation) is not behaving as expected: " << distance
+              << "\n";
     return EXIT_FAILURE;
   }
 
   if (!compareDouble(azimuth, 0.0))
   {
-    std::cerr << "getWorldAzimuth (negative elevation) is not behaving as expected: "
-              << azimuth << "\n";
+    std::cerr << "getWorldAzimuth (negative elevation) is not behaving as expected: " << azimuth
+              << "\n";
     return EXIT_FAILURE;
   }
 

[Dtsitos]

\ci full

[mwestphal]

not ready for full CI yet :)

[mwestphal]

do you need help with the style check @Dtsitos ?