Fix SynthTraceSerializationTest for Windows #1577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: MSVC has stringizing bug where it doesn't process code units in raw string literals. See example: https://godbolt.org/z/osjYj95rq Temporary fix is to move the string literal out of the `EXPECT_EQ` macro until this gets fixed. Reviewed By: neildhar Differential Revision: D66914807
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66914807 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: Pull Request resolved: #1577 MSVC has stringizing bug where it doesn't process code units in raw string literals. See example: https://godbolt.org/z/osjYj95rq Temporary fix is to move the string literal out of the `EXPECT_EQ` macro until this gets fixed. Reviewed By: neildhar Differential Revision: D66914807 fbshipit-source-id: 947d4f2254d23ee322dcc063b40f8d05575987d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MSVC has stringizing bug where it doesn't process code units in raw
string literals. See example: https://godbolt.org/z/osjYj95rq
Temporary fix is to move the string literal out of the
EXPECT_EQmacrountil this gets fixed.
Reviewed By: neildhar
Differential Revision: D66914807