Skip to content

Add name prop to StrictReactDOMInputProps #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ksheedlo
Copy link

Copy link
Contributor

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting name will need more changes than this. I'll do it

@@ -21,6 +21,7 @@ export type StrictReactDOMInputProps = $ReadOnly<{
min?: ?(string | number),
minLength?: ?number,
multiple?: ?boolean,
name?: ?Stringish,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same change is needed in StrictReactDOMTextAreaProps - https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/textarea#name

necolas added a commit that referenced this pull request May 21, 2025
Allows this attribute to be used on web. No support for native at this
time.

Close #309
@necolas
Copy link
Contributor

necolas commented May 21, 2025

@ksheedlo Added you as reviewer to #310

@necolas necolas closed this May 21, 2025
necolas added a commit that referenced this pull request May 21, 2025
Allows this attribute to be used on web. No support for native at this
time.

Close #309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants