Skip to content

Allow "name" attribute for input, select, textarea elements #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

necolas
Copy link
Contributor

@necolas necolas commented May 21, 2025

Allows this attribute to be used on web. No support for native at this time.

Close #309

Allows this attribute to be used on web. No support for native at this
time.

Close #309
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,515 2,513 1.00 -
· minified 8,688 8,695 1.00 +
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 15,969 15,952 1.00 -
· minified 59,663 59,670 1.00 +

Copy link

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,117,753 1,136,122 1.02 +
· small with units 443,976 441,927 1.00 -
· small with variables 681,604 657,645 0.96 -
· several small 323,645 322,936 1.00 -
· large 211,959 210,420 0.99 -
· large with polyfills 147,590 144,881 0.98 -
· complex 100,650 99,536 0.99 -
· unsupported 222,638 220,354 0.99 -
css.createTheme
· simple theme 230,230 231,662 1.01 +
· polyfill theme 220,104 218,671 0.99 -
css.props
· small 240,172 241,517 1.01 +
· small with units 187,535 189,808 1.01 +
· small with variables 104,974 105,424 1.00 +
· small with variables of units 74,729 74,610 1.00 -
· large 102,446 102,847 1.00 +
· large with polyfills 37,111 37,224 1.00 +
· complex 23,729 23,686 1.00 -
· unsupported 148,337 149,159 1.01 +
· simple merge 161,779 161,981 1.00 +
· wide merge 17,794 17,889 1.01 +
· deep merge 17,524 17,530 1.00 +
· themed merge 32,034 32,080 1.00 +

Copy link

@ksheedlo ksheedlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@necolas necolas merged commit f3d218f into main May 21, 2025
8 checks passed
@necolas necolas deleted the add/input-name branch May 21, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants