Group
trait overhaul part 2
#53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #52.
expand_message_xmd
and useExpandMsgXmd
ofelliptic-curve
instead.CipherSuite
and moveSUITE_ID
to there. This allows consumers to implement their own group and hash combination and assign a custom suite id.voprf
types.Group
for RustCryptoCurve
s.Group
implementation forNistP256
.ristretto255_*
crate features toristretto255-*
.We should probably properly document
CipherSuite
and theristretto255-ciphersuite
crate feature. I hope you like these changes @kevinlewi, I couldn't find any other way to properly do this.This is still waiting for RustCrypto/traits#906 and RustCrypto/elliptic-curves#515.