Fix vdso_get_symbols_info() assertion for ARM64 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
On ARM64 I have been seeing test failures: ``` test vdso::tests::vdso_can_find_symbols_info ... FAILED test vdso::tests::vdso_patch_info_is_valid ... FAILED ``` Looking closer, this was caused by the debug assertion in vdso_get_symbols_info() which asserts that all symbols found in the VDSO are ELF STT_FUNC symbols. Unfortunately, this is not the case on ARM64, because the VDSO's `__kernel_rt_sigreturn` is special and does appear as STT_NONE symbol. Fixup the debug assertion by special-casing for this special function. Signed-off-by: Bjoern Doebel <[email protected]>
|
@jasonwhite has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jasonwhite merged this pull request in 626198d. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ARM64 I have been seeing test failures:
Looking closer, this was caused by the debug assertion in vdso_get_symbols_info() which asserts that all symbols found in the VDSO are ELF STT_FUNC symbols. Unfortunately, this is not the case on ARM64, because the VDSO's
__kernel_rt_sigreturnis special and does appear as STT_NONE symbol.Fixup the debug assertion by special-casing for this special function.
Note: I shortly considered adding an expected symbol type to the
VDSO_SYMBOLShashes, but that didn't seem to make sense just to fix this one special case.